Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ime and enable build option #1999

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

amosbird
Copy link
Contributor

@amosbird amosbird commented Jul 9, 2024

This is a follow-up fix PR to #1735 which makes fcitx5 work perfectly in rofi.

@DaveDavenport DaveDavenport merged commit 8b612f0 into davatorium:next Jul 9, 2024
8 checks passed
@amosbird
Copy link
Contributor Author

amosbird commented Jul 9, 2024

@DaveDavenport Oops. It somehow doesn't work with modifiers. That means, when invoking rofi using mod + keys, it fails to release the mod key and disrupts interaction. I'll submit another PR to avoid forwarding modifiers ftm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants